Skip to content

Issue337 move data#339

Open
mortenwh wants to merge 39 commits into
masterfrom
issue337_move_data
Open

Issue337 move data#339
mortenwh wants to merge 39 commits into
masterfrom
issue337_move_data

Conversation

@mortenwh

@mortenwh mortenwh commented Aug 1, 2024

Copy link
Copy Markdown
Collaborator

Summary: closes #337

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license (i.e., "License: This file is part of py-mmd-tools, licensed under the Apache License 2.0 (https://www.apache.org/licenses/LICENSE-2.0)")
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see https://s-enda-documentation.readthedocs.io/en/latest/general_conventions.html). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@mortenwh mortenwh requested review from Teddy-1000 and myggen and removed request for myggen December 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool to move data and update MMD files accordingly

1 participant