Accept an existing datatype in empty_as and with_data_as - #223
Merged
Conversation
CramBL
changed the title
CramBL
force-pushed
the
dataset-with-datatype
branch
4 times, most recently
from
September 6, 2026 16:25
5f505d8 to
da61f56
Compare
mulimoen
force-pushed
the
dataset-with-datatype
branch
from
September 6, 2026 17:24
da61f56 to
daace78
Compare
mulimoen
reviewed
Sep 6, 2026
Signed-off-by: Magnus Ulimoen <mulimoen@users.noreply.github.com>
Collaborator
|
Thanks a lot for you work @CramBL, splitting the PRs made reviewing a bit easier than having it all in one go. The new API for commited datatypes feels quite ergonomic, hope to see users adopting it! |
Collaborator
|
And do let me know if you want me to cut a new release (0.15.0) or if you have more changes coming :) |
Author
Thanks, that's all for now 😄 I just took ownership of hdf5-pure and it would be weird if I didn't find more features or issues while I cross-reference the implementation with hdf5-rust and the HDF5 spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #219, #220, & #222
Resolves #221
Resolves #215 (the parent issue of the whole
comitted datatypefeature)