fix(blaze): rename reserved arguments parameter to fix SWC transpilation#508
Closed
italojs wants to merge 1 commit into
Closed
fix(blaze): rename reserved arguments parameter to fix SWC transpilation#508italojs wants to merge 1 commit into
italojs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blaze/exceptions.jscaused by usingargumentsas a rest parameter name (...arguments), which is a reserved identifier in strict mode...argumentsto...argsinBlaze._wrapCatchingExceptionsProblem
The SWC transpiler fails to parse
blaze/exceptions.jsbecauseargumentscannot be used as a binding identifier in strict mode (ES module context). This causes a fallback to Babel with the error:[Transpiler] Used Babel for blaze/exceptions.js (package)⚠️ Fallback
↳ Error: x 'eval' and 'arguments' cannot be used as a binding identifier in strict mode
This error is currently occurring in CI (see failing job) and can be reproduced locally by running: