Repository navigation
fix: shared cross-thread 429 backoff gate instead of per-request retry - #5
Merged
Merged
Conversation
Gateway RateLimit-Reset header often returns '0', so the old retry loop waited 0s and retried instantly, deepening throttling (limit dropped 50->25->12->6 req/60s within seconds under concurrent load). Each thread also decided independently with no shared state. Add a process-wide rate-limit gate: 429 backs off with floor/cap exponential wait + jitter (ignoring the unreliable header value), and every request (any thread, any HTTPClient instance) waits on the same gate before firing. 429 retries get their own budget, separate from generic/TGT retry counts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway RateLimit-Reset header often returns '0', so the old retry loop waited 0s and retried instantly, deepening throttling (limit dropped 50->25->12->6 req/60s within seconds under concurrent load). Each thread also decided independently with no shared state.
Add a process-wide rate-limit gate: 429 backs off with floor/cap exponential wait + jitter (ignoring the unreliable header value), and every request (any thread, any HTTPClient instance) waits on the same gate before firing. 429 retries get their own budget, separate from generic/TGT retry counts.
Değişiklik Açıklaması
Bu PR'ın ne yaptığını açık ve öz bir şekilde açıklayın.
Değişiklik Türü
Lütfen ilgili kutucuğu işaretleyin:
İlgili Issue
Bu PR hangi issue'yu çözüyor? (varsa)
Closes #
Değişiklik Detayları
Ne Değişti?
Neden Değişti?
Değişikliğin nedenini açıklayın.
Nasıl Test Edildi?
Değişikliklerin nasıl test edildiğini açıklayın:
Test Sonuçları
Ekran Görüntüleri
Varsa, değişiklikleri gösteren ekran görüntüleri ekleyin.
Kontrol Listesi
PR göndermeden önce aşağıdakileri kontrol edin:
black,isort)Breaking Changes
Bu PR breaking change içeriyor mu?
Breaking Changes Detayları
Eğer breaking change varsa, detaylarını açıklayın:
Ek Notlar
Eklemek istediğiniz başka bir şey var mı?
Review Notları
Reviewer'lar için özel notlar (varsa):