Skip to content

feature: Support writing predictions to extxyz files - #1256

Merged
pfebrer merged 3 commits into
metatensor:mainfrom
AntObi:chore/support_extxyz_files_for_mtt_eval
Aug 28, 2026
Merged

feature: Support writing predictions to extxyz files#1256
pfebrer merged 3 commits into
metatensor:mainfrom
AntObi:chore/support_extxyz_files_for_mtt_eval

Conversation

@AntObi

@AntObi AntObi commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

Maintainer/Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?
  • GPU tests passed (maintainer comment: "cscs-ci run")?

📚 Documentation preview 📚: https://metatrain--1256.org.readthedocs.build/en/1256/

@ceriottm

Copy link
Copy Markdown
Contributor

to my understanding, .xyz output is ALREADY effectively extxyz (which itself is a non-standard suffix for a non-standard extension of a non-standard format)

@pfebrer

pfebrer commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Yes, this is what we discussed in the issue.

I guess this comes down to: @AntObi, will you use it? :)

I think if there is somebody who thinks their life will be easier then it should not be a problem to have it around and it's worth it, otherwise it's just an unnecessary feature 😅

@pfebrer

pfebrer commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

I'm also very happy that external humans contribute, so if you think it's going to be used it's all good for me 👍 I'd rather not start a phylosophical debate on this one haha

@Luthaf

Luthaf commented Aug 28, 2026

Copy link
Copy Markdown
Member

cscs-ci run

@AntObi

AntObi commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

to my understanding, .xyz output is ALREADY effectively extxyz (which itself is a non-standard suffix for a non-standard extension of a non-standard format)

Yes, this is what we discussed in the issue.

I guess this comes down to: @AntObi, will you use it? :)

I think if there is somebody who thinks their life will be easier then it should not be a problem to have it around and it's worth it, otherwise it's just an unnecessary feature 😅

I'm also very happy that external humans contribute, so if you think it's going to be used it's all good for me 👍 I'd rather not start a phylosophical debate on this one haha

Yep, it's something that I would use. Additionally, it adds a bit of consistency, since Metatrain supports reading both .xyz and .extxyz files,

DEFAULT_READER = {
".xyz": "ase",
".extxyz": "ase",
".mts": "metatensor",
}

so it should also support both file extensions for writing as well.

@pfebrer

pfebrer commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@pfebrer
pfebrer merged commit 4ee4372 into metatensor:main Aug 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support writing predictions from mtt eval to extxyz files.

4 participants