feature: Support writing predictions to extxyz files - #1256
Conversation
|
to my understanding, .xyz output is ALREADY effectively extxyz (which itself is a non-standard suffix for a non-standard extension of a non-standard format) |
|
Yes, this is what we discussed in the issue. I guess this comes down to: @AntObi, will you use it? :) I think if there is somebody who thinks their life will be easier then it should not be a problem to have it around and it's worth it, otherwise it's just an unnecessary feature 😅 |
|
I'm also very happy that external humans contribute, so if you think it's going to be used it's all good for me 👍 I'd rather not start a phylosophical debate on this one haha |
|
cscs-ci run |
Yep, it's something that I would use. Additionally, it adds a bit of consistency, since Metatrain supports reading both metatrain/src/metatrain/utils/data/readers/readers.py Lines 19 to 23 in e2af067 so it should also support both file extensions for writing as well. |
|
Thanks! |
mtt evalto extxyz files. #1255, which enables predictions frommtt evalto also be written toextxyzfiles in the same format as the currently supportedxyzfor any usage where users may prefer theextxyzfile format.Contributor (creator of pull-request) checklist
Maintainer/Reviewer checklist
📚 Documentation preview 📚: https://metatrain--1256.org.readthedocs.build/en/1256/