Added example that shows how to sync subscriptions #85
Draft
Added example that shows how to sync subscriptions #85
Conversation
…e updated regularly on spotify) to tidal
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
semohr
reviewed
Apr 8, 2026
|
|
||
| for i in range(0, len(ops.ops), batch_size): | ||
| batch = ops.ops[i : i + batch_size] | ||
| # PS@SM: ops.ops is needed, itering ops gives steps and instance checks fail |
Contributor
There was a problem hiding this comment.
We use two type ignores for this if you check playlist.py:393. We might want to move this logic somehow into the core layer I guess. I wouldn't want users to use the ops if it is not entirely necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I follow some playlists that are updated regularly on spotify via tidal.
This might be a cool example and good use-case to show.
I was tweaking this a bit more, and after the refactor it works quite well.
If we fix some of the open issues (retry logic) the code should also be much shorter.