Skip to content

Tidal api fixes#83

Merged
semohr merged 5 commits intomainfrom
tidal_api_fixes
Apr 15, 2026
Merged

Tidal api fixes#83
semohr merged 5 commits intomainfrom
tidal_api_fixes

Conversation

@pSpitzner
Copy link
Copy Markdown
Contributor

@pSpitzner pSpitzner commented Apr 4, 2026 •
edited by semohr
Loading

Based on #80
(I needed both changes to get my sync script to run, and explore whats in the current PR)

  • add default rate limit of 4 requests per second on tidal, so we avoid 429 which slow us down even more
  • batched inserts and deletions, to avoid server side errors that would occur for long lists of track changes via single request. No idea what the upper batch size is though, was hard to reproduce.

@github-actions

This comment was marked as resolved.

Sign in to view
@pSpitzner pSpitzner temporarily deployed to integration_tests April 4, 2026 15:49 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
plistsync/services/tidal/api.py 4.34% 22 Missing ⚠️

📢 Thoughts on this report? Let us know!

@pSpitzner pSpitzner temporarily deployed to integration_tests April 4, 2026 16:49 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests April 4, 2026 16:49 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests April 4, 2026 16:59 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests April 4, 2026 16:59 — with GitHub Actions Inactive
pSpitzner and others added 4 commits April 15, 2026 17:36
@pSpitzner @semohr
moved the fix to proper place
ab27fb4
@pSpitzner @semohr
Added base rate limit. If we avoid running into the 429 error, we hav…
53d71a7 
…e to wait less.
@pSpitzner @semohr
Added batching to tidal remote inserts and deletes. I encountered err…
831670c 
…ors (i think 400

and 500) if the lists get too long. Seems to work fine with batches of 20, but I have
not experimented with higher numbers.

Maybe we should better do this on the api side?
@semohr
Reuse existing functions.
fd178d1
@semohr semohr temporarily deployed to integration_tests April 15, 2026 15:41 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests April 15, 2026 15:41 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests April 15, 2026 15:43 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests April 15, 2026 15:43 — with GitHub Actions Inactive
@semohr semohr merged commit 44066af into main Apr 15, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@semohr semohr semohr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pSpitzner @semohr