Open
Conversation
There was a problem hiding this comment.
why catch and suppress Throwable rather than Exception or IOException?
There was a problem hiding this comment.
nm, didn't realize this was metamx/druid. do what you want :)
There was a problem hiding this comment.
But really, this will catch things like OOME, which is probably not want to be caught.
Suggest checking for Exception, and throwing if is a fatal type.
nishantmonu51
force-pushed
the
0.8.3-mmx-debug
branch
from
e1e080b to
c8691f3
Compare
review comment review comments
nishantmonu51
force-pushed
the
0.8.3-mmx-debug
branch
from
c8691f3 to
6195e79
Compare
| return taskAction.perform(task, toolbox); | ||
| RetType rv = taskAction.perform(task, toolbox); | ||
| log.debug( | ||
| "Completed action for task[%s]: %s. Took [%d]ms", |
There was a problem hiding this comment.
Completed action for task[%s]: %s in [%d]ms might be easier to read
|
@nishantmonu51 I think we can submit this directly to upstream and merge into our 0.9 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.