fix: macOS IPC hang, zombie processes and worker crashes#135
Open
prathamtomar99 wants to merge 2 commits intometacall:masterfrom
Open
fix: macOS IPC hang, zombie processes and worker crashes#135prathamtomar99 wants to merge 2 commits intometacall:masterfrom
prathamtomar99 wants to merge 2 commits intometacall:masterfrom
Conversation
On macOS, metacall is a bash wrapper that silently breaks Node.js IPC, causing all function calls to hang forever after deploy. Changes: - Spawn metacallcli directly on macOS, detect via process.platform - Derive install prefix dynamically from Cellar (no hardcoded paths) - Auto-restart worker on crash, reject orphaned calls immediately - Kill zombie processes on failed startup reload - Add matrix tests for macOS/Linux/Windows (26 passing, 4 pending)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
Summary
On macOS,
metacallis a bash wrapper that breaks Node.js IPC silently —every function call hangs forever. Found this while setting up locally for GSoC.
Fixed by spawning
metacallclidirectly with env vars replicated from thewrapper. Also fixed the TODO in deploy.ts — worker now auto-restarts on crash
and orphaned calls get rejected immediately instead of hanging.
Type of change
How to test
Notes for reviewers
if (isMacOS)— Linux/Windows untouchedRelease notes
Fixed function calls hanging forever on macOS Homebrew installs.