Fix(#119): deleteFolder should use fs.rm to remove directories#132
Open
everleepham wants to merge 1 commit intometacall:masterfrom
Open
Fix(#119): deleteFolder should use fs.rm to remove directories#132everleepham wants to merge 1 commit intometacall:masterfrom
everleepham wants to merge 1 commit intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
deleteFolderhelper insrc/controller/package.tsto usefs.rm()with{ recursive: true, force: true }instead offs.unlink().fs.unlinkis a unlink syscall and can only remove files so when it is called on a directory it fails withEISDIRon Linux/macOS orEPERMon Windows, leaving orphaned application directories on disk after failed uploads.Related issue
Fixes #119
Type of change
How to test
npm cinpm test-> all 16 tests should pass, including 2 new tests in theFix: deleteFolder should use fs.rm to remove directoriesChecklist
Notes for reviewers
fs.rm(path, { recursive, force }, cb)is available since Node 14.14, this project requires Node ≥18.17, so it's safe.fs.rmpattern is already used insrc/index.tsandsrc/controller/repository.tsdeleteBlob(line 155) correctly usesfs.unlinksince it removes a single file, no need to change.