Repository navigation
[Nexthop][distro] Make pxeboot_complete not empty - #1913
Draft
travisb-nexthop wants to merge 1 commit into
Draft
travisb-nexthop wants to merge 1 commit into
travisb-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: Travis Brown <travisb@nexthop.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
iPXE commit de4302490 fixed a bug where empty TFTP files were mistakenly accepted through a NULL pointer access mapping to a real page.
After that change, a file of zero size is rejected because block bitmap operations fail when the bitmap does not exist.
Make the pxeboot_complete marker file not empty so it has a real size and is therefore supported.
Test Plan
Prior to this fix, iPXE would fail downloading the marker file and therefore fail the installation:
Afterwards, it successfully proceeds past that point: