Skip to content

[Nexthop][distro] Support IPv6 Link-local IPs in fboss-image device - #1912

Draft
travisb-nexthop wants to merge 1 commit into
meta:mainfrom
nexthop-ai:support-ipv6-link-local-ips-in-fboss
Draft

travisb-nexthop wants to merge 1 commit into
meta:mainfrom
nexthop-ai:support-ipv6-link-local-ips-in-fboss

Conversation

@travisb-nexthop

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

In several places fboss-image was not correctly specifying the IPv6 zone (eg. interface) and this was preventing some device commands, such as reprovision, from correctly working with pure IPv6-only, link-local-only devices.

When an IPv6 link-local IP is selected, add the interface as the zone.

Test Plan

Tested by provisioning an IPv6-only, link-local-only dut:

$ ip -6 addr
...
323: tap-fboss103: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UNKNOWN qlen 1000
    inet6 fe80::94e4:1aff:fe3b:4563/64 scope link 
       valid_lft forever preferred_lft forever
$ ./distro_cli/fboss-image device dc:da:4d:fc:ad:2d reprovision
[0.00s] Checking if container is running: fboss-distro-infra
[0.03s] Checking if container is running: fboss-distro-infra
[0.09s] Executing command in container fboss-distro-infra: ['/distro_infra/getip.sh', 'dc:da:4d:fc:ad:2d', 'tap-fboss103']
Warning: Permanently added 'fe80::deda:4dff:fefc:ad2d%tap-fboss103' (ED25519) to the list of known hosts.
root@fe80::deda:4dff:fefc:ad2d%tap-fboss103's password: 
50+0 records in
50+0 records out
52428800 bytes (52 MB, 50 MiB) copied, 0.0180015 s, 2.9 GB/s
Warning: Partition /dev/nvme0n1p3 is being used. Are you sure you want to continue?
Yes/No? yes                                                               
Ignore/Cancel? ignore                                                     
Error: Partition(s) 3 on /dev/nvme0n1 have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use.  As a result, the old partition(s) will remain in use.  You should reboot now before making further changes.
Information: You may need to update /etc/fstab.

Rebooting.

Signed-off-by: Travis Brown <travisb@nexthop.ai>
@meta-cla meta-cla Bot added the CLA Signed label Nov 4, 2026
@github-actions github-actions Bot added nexthop project:distro FBOSS project: distro labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant