Speed up sharding optimizer build#513
Open
AlbedoWang wants to merge 1 commit into
Open
Conversation
This reduces optimizer construction overhead while preserving the solver-visible problem. The build now skips discarded enumeration-time redistribute costs, prunes invalid edges before PuLP variable creation, stores repeated-subgraph cluster links at node granularity, and can construct edge costs in deterministic worker order. Authored with Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces AutoParallel sharding optimizer build time while preserving the solver-visible optimization problem and selected placements.
The main changes are:
redistribute_costwork during sharding metadata construction. Those costs are not consumed by the solver directly; AutoParallel recomputes and stores its own edge costs before building the ILP objective.(node, arg, output, input)option. Identical repeated nodes resolve to their root node using matching option indices, reducing cluster bookkeeping size.AP_PARALLEL_BUILD, with serial fallback when CUDA has already been initialized.AP_FAST_BUILD=0as an A/B switch for disabling the enumeration-time shortcut.