cwalk: new package

[antoniovazquezblanco]

No description provided.

[antoniovazquezblanco]

A release was pushed with fixed meson version.

likle/cwalk#42

[antoniovazquezblanco]

It seems the default option for default_libraries is shared. See https://mesonbuild.com/Builtin-options.html

For some reason, Visual Studio check script is checking for the presence of the static one... Something wrong on my end?

Thanks!

[neheb]

ERROR: File 'subprojects/cwalk-1.2.8/cwalk.lib' could not be found

is caused by no functions being exported. This can be fixed with a custom def file.

edit: I see the problem. CMakeLists.txt and meson.build differ. CWK_SHARED must be passed when building as shared.

[antoniovazquezblanco]

This is being fixed upstream likle/cwalk#46

[antoniovazquezblanco]

Now all tests pass! :D

[antoniovazquezblanco]

Upstream fix at likle/cwalk#47

[antoniovazquezblanco]

From upstream, @likle asks:

I am not verify familiar with meson, doesn't "both" mean it builds shared as well as static?
Wouldn't that set it to CWK_SHARED for the static build done using the both option?

[antoniovazquezblanco]

Ping @neheb :)

[antoniovazquezblanco]

Thanks @neheb!

Do you have an answer for #1387 (comment) ?

How does meson deal with dual builds?

Thanks again!!

[benoit-pierre]

Meson 1.3.0 has support for dedicated shared/static language arguments to library(…): https://mesonbuild.com/Reference-manual_functions.html#library__lang__shared_args.

[neheb]

both builds both shared and static. When using in a dependency, the shared is used by default. In wraps around here, typically != static is checked to enable a SHARED macro.

[benoit-pierre]

But the static library will be built with the wrong flags:

project('bothlibs', 'c')

library(
  'both',
  configure_file(configuration: {}, macro_name: 'both', output: 'both.c'),
  c_args: get_option('default_library') != 'static' ? '-DSHARED' : [],
)

▸ meson setup --prefix="$PWD/dist/native" --default-library=both -- build/native
[…]
▸ meson compile -C build/native --ninja-args= -v
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /home/bpierre/tmp/bothlibs/build/native -v
ninja: Entering directory `/home/bpierre/tmp/bothlibs/build/native'
[1/3] ccache cc -Ilibboth.so.p -I. -I../.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fPIC -DSHARED -MD -MQ libboth.so.p/meson-generated_.._both.c.o -MF libboth.so.p/meson-generated_.._both.c.o.d -o libboth.so.p/meson-generated_.._both.c.o -c both.c
[2/3] rm -f libboth.a && gcc-ar csrDT libboth.a libboth.so.p/meson-generated_.._both.c.o
[3/3] cc  -o libboth.so libboth.so.p/meson-generated_.._both.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,-soname,libboth.so

[benoit-pierre]

IMHO, wraps that need special shared/static arguments should use <lang>_shared_args / <lang>_static_args when available and otherwise error on meson < 1.3.0 when building with --default-library=both.

[neheb]

Right. It’s usually not an issue with GCC based compilers but not MSVC. The best solution for MSVC currently is to avoid these and use def files.