Abort JoinHandle when futures are cancelled/dropped#100
Open
Abort JoinHandle when futures are cancelled/dropped#100
Conversation
Use the new `AbortingJoinHandle` to cancel a JoinHandle (using `JoinHandle::abort()`) when `AbortingJoinHandle` is dropped.
No reason to implement our own AbortingJoinHandle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automatic task abortion for background tasks to ensure they are cleaned up when their handles are dropped. It refactors the management of read, write, processing, heartbeat, and bridge handlers to use
tokio_util::task::AbortOnDropHandle.This prevents resource leaks and ensures clean shutdowns when operations (such as
connect()) are cancelled, for example by atokio::time::timeout.Related Issues
Fixes #88
Proposed Changes
ConnectedStreamApiandStreamHandleto useAbortOnDropHandle. This ensures that background tasks are aborted immediately when the API object is dropped or when aconnect()future is cancelled.bridge_handlefor low-level transports (like BLE), ensuring it is aborted and awaited during disconnection.rtfeature fortokio-utilinCargo.toml.Checklist