Long name reduction#945
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the nanopb max_size allocations for various long_name string fields from 40 to 25, presumably to reduce RAM usage in embedded builds that use these .options files.
Changes:
- Reduce
MapReport.long_namenanopbmax_sizeto 25 inmqtt.options. - Reduce
User.long_namenanopbmax_sizeto 25 inmesh.options. - Reduce
UserLite.long_nameandDeviceProfile.long_namenanopbmax_sizeto 25 indeviceonly.options/clientonly.options.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| meshtastic/mqtt.options | Lowers MapReport.long_name nanopb buffer size. |
| meshtastic/mesh.options | Lowers User.long_name nanopb buffer size. |
| meshtastic/deviceonly.options | Lowers UserLite.long_name nanopb buffer size. |
| meshtastic/clientonly.options | Lowers DeviceProfile.long_name nanopb buffer size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| *ServiceEnvelope.gateway_id type:FT_POINTER | ||
|
|
||
| *MapReport.long_name max_size:40 | ||
| *MapReport.long_name max_size:25 |
| *public_key max_size:32 # public key | ||
|
|
||
| *User.long_name max_size:40 | ||
| *User.long_name max_size:25 |
| @@ -1,4 +1,4 @@ | |||
| *DeviceProfile.long_name max_size:40 | |||
| *DeviceProfile.long_name max_size:25 | |||
| *NodeInfoLite.role int_size:8 | ||
|
|
||
| *UserLite.long_name max_size:40 | ||
| *UserLite.long_name max_size:25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.