ci: hold Kotlin at 2.3.x until Meshtastic-Android can consume 2.4-built klibs#944
Closed
jamesarich wants to merge 1 commit into
Closed
ci: hold Kotlin at 2.3.x until Meshtastic-Android can consume 2.4-built klibs#944jamesarich wants to merge 1 commit into
jamesarich wants to merge 1 commit into
Conversation
…lt klibs
Klibs produced by Kotlin 2.4 carry ABI version 2.4.0, which Kotlin 2.3.x
consumers reject ("current Kotlin compiler can consume libraries having
ABI version <= 2.3.0"). Meshtastic-Android is pinned to 2.3.21 until the
Koin compiler plugin supports 2.4 (InsertKoinIO/koin#2431), so a Kotlin
bump here would make the next org.meshtastic:protobufs release
unconsumable for it. Same guard as MQTTastic-Client-KMP.
Drop this rule once Meshtastic-Android lands its Kotlin 2.4 upgrade.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).
|
Contributor
Author
|
Closing as obsolete: this hold existed because Meshtastic-Android was stuck on Kotlin 2.3.21 (2.4-built native klibs carry ABI 2.4.0, which 2.3.x consumers reject). Android merged its Kotlin 2.4.0 upgrade today (meshtastic/Meshtastic-Android#5760), so the hold is no longer needed — better to never land it than to land and revert. The matching hold in MQTTastic-Client-KMP is being removed in meshtastic/MQTTastic-Client-KMP#56. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The KMP artifact (
org.meshtastic:protobufs, added in #924) publishes native klibs. Klibs built by Kotlin 2.4 carry ABI version 2.4.0, which Kotlin 2.3.x consumers hard-reject:Meshtastic-Android is pinned to Kotlin 2.3.21 until the Koin compiler plugin supports 2.4 (InsertKoinIO/koin#2431), and meshtastic/Meshtastic-Android#5675 makes it consume this artifact directly. Without this guard, a routine Renovate Kotlin bump here would make the next
org.meshtastic:protobufsrelease silently unconsumable for the app.This already bit us with the other two KMP libs: MQTTastic-Client-KMP 0.3.7 and TAKPacket-SDK 0.5.3 were built on Kotlin 2.4.0, which is why meshtastic/Meshtastic-Android#5763 fails CI. MQTTastic is getting the same Renovate guard.
What
A single Renovate
packageRulesentry holdingorg.jetbrains.kotlin*(plugin ids and maven coords;kotlinxis unaffected) below 2.4.0.Drop this rule once Meshtastic-Android lands its Kotlin 2.4 upgrade (meshtastic/Meshtastic-Android#5760).
🤖 Generated with Claude Code