Add T-Deck Max hardware model#942
Draft
h3lix1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
T_DECK_MAX = 139to the sharedHardwareModelenum.Why this is necessary
Firmware needs a stable hardware model ID before the T-Deck Max variant can be represented correctly in device info, clients, and generated firmware headers. The current protobuf
masterbranch already uses 137 forSEEED_WIO_TRACKER_L2and 138 forCROWPANEL_P4, so T-Deck Max takes the next open value: 139.What changed
HardwareModelenum value:T_DECK_MAX = 139Tests
trunk fmt protobufs/meshtastic/mesh.protofrom the firmware checkout. No applicable linter was configured for this path.git -C protobufs diff --checkReviewer notes
This PR intentionally only reserves the protobuf ID. Firmware support should follow in a separate firmware PR after this protobuf entry is available for generated outputs and the firmware submodule pointer.