feat(device_ui): add bearings_view_radar and radar_favorites_only fields#935
Open
egorsiniaev wants to merge 1 commit into
Open
feat(device_ui): add bearings_view_radar and radar_favorites_only fields#935egorsiniaev wants to merge 1 commit into
egorsiniaev wants to merge 1 commit into
Conversation
Open
9 tasks
Author
|
Hey @fifieldt. Could you take a look on this PR? It's blocking meshtastic/firmware#10224 to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bearings_view_radar(field 20) — when true, the bearings/distance frame is replaced by the radar overlayradar_favorites_only(field 21) — when true, the radar overlay only plots favorite nodesContext
These fields are required by the radar minimap feature in the Meshtastic firmware:
meshtastic/firmware#10224
Both fields are
bool, backwards-compatible (default false = existing behaviour unchanged), and follow the existingDeviceUIConfignumbering aftergps_format = 19.