Skip to content

fix: new PKI_DECRYPT_FAILED response instead of NO_CHANNEL when PKI decryption fails#10305

Open
llamafilm wants to merge 2 commits into
meshtastic:developfrom
llamafilm:pki-decrypt-failed
Open

fix: new PKI_DECRYPT_FAILED response instead of NO_CHANNEL when PKI decryption fails#10305
llamafilm wants to merge 2 commits into
meshtastic:developfrom
llamafilm:pki-decrypt-failed

Conversation

@llamafilm

@llamafilm llamafilm commented Apr 25, 2026

Copy link
Copy Markdown

Fixes #6074 and discussions #6079 and #10210.

This change depends on a new protobuf definition: meshtastic/protobufs#901

When a PKI message fails to decrypt, it previously responded with NO_CHANNEL, which is misleading at best, and arguably inaccurate. Now it responds with PKI_DECRYPT_FAILED instead.

The current iOS app displays this unknown error code in the UI as "Empty Ack Error". It will need an update to handle the new error code.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@CLAassistant

CLAassistant commented Apr 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the bugfix Pull request that fixes bugs label Apr 25, 2026
@jp-bennett

Copy link
Copy Markdown
Collaborator

This is probably the right idea. In the past we hadn't done this because hash 0x0 could be a regular channel. But now that we have completely deprecated legacy DMs, we would be even more confident it was intended to be a DM.

@github-actions github-actions Bot added the Stale Issues that will be closed if not triaged. label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs Stale Issues that will be closed if not triaged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: No channel while trying to send DM

4 participants