fix: new PKI_DECRYPT_FAILED response instead of NO_CHANNEL when PKI decryption fails#10305
Open
llamafilm wants to merge 2 commits into
Open
fix: new PKI_DECRYPT_FAILED response instead of NO_CHANNEL when PKI decryption fails#10305llamafilm wants to merge 2 commits into
llamafilm wants to merge 2 commits into
Conversation
|
|
Collaborator
|
This is probably the right idea. In the past we hadn't done this because hash 0x0 could be a regular channel. But now that we have completely deprecated legacy DMs, we would be even more confident it was intended to be a DM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6074 and discussions #6079 and #10210.
This change depends on a new protobuf definition: meshtastic/protobufs#901
When a PKI message fails to decrypt, it previously responded with NO_CHANNEL, which is misleading at best, and arguably inaccurate. Now it responds with PKI_DECRYPT_FAILED instead.
The current iOS app displays this unknown error code in the UI as "Empty Ack Error". It will need an update to handle the new error code.
🤝 Attestations