release: 2.8.0#5738
Draft
jamesarich wants to merge 15 commits into
Draft
Conversation
Contributor
✅ Preview staleness check passedPreview and screenshot references are up to date. |
Contributor
✅ Docs staleness check passedThis PR includes updates to |
Contributor
✅ Screenshot reference staleness passedPreview and screenshot references are up to date. |
befa7fb to
25cc141
Compare
Opening commit for the release/2.8.0 stabilization branch. versionCode remains git-derived (offset 29314197 + commit count); only the base version name is bumped here. CI overrides this with the release tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enables the full validate-and-build pipeline on PRs whose base is a release branch (e.g. release/2.8.0), not just main, so milestone PRs retargeted onto the release branch get per-PR CI before merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…ings directory) (#5714) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…cher (#5765) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
#5275 created :feature:discovery with implementation(projects.core.proto), but main's #5675 replaced the :core:proto submodule with the org.meshtastic:protobufs Maven artifact. Rebasing left a stale module reference. Switched to implementation(libs.meshtastic.protobufs), matching the convention (cf. feature/node). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eline for 2.8.0 (#5775) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…AtStart The google-flavor AppFunctionsModule registered AppFunctionStateSync with createdAtStart = true. Eager creation needs the androidContext binding and immediately spawns the prefs-observing sync coroutine — so any Koin graph built outside a running app failed with NoDefinitionFoundException for android.content.Context. That broke KoinVerificationTest.verifyTypedBootstrapLoadsModuleGraph (the typed koinApplication<AndroidKoinApp>() bootstrap instantiates eager singletons), failing the shard-app CI job on this branch. The definition is now a plain @single (the graph stays lazily constructible) and GoogleMeshUtilApplication.onCreate resolves it once after startKoin has bound androidContext — same production behavior, explicit instead of implicit. It was the repo's only createdAtStart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: James Rich <james.a.rich@gmail.com>
ea06782 to
0a4c22b
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
configureCommon() applied setMultipleConnectionPool(maxNumOfReaders = 4) to every database, including the in-memory ones used by tests. A read on a pooled reader connection can observe a snapshot older than the latest write on the writer connection, so a read immediately after a write may return stale rows. DeviceLinkRepositoryImplTest.reconcilePrunesShortCodesNoLongerInCatalog read [a, b] (the pre-prune state) instead of [a] after a deleteNotIn — passing locally but flaking on CI depending on connection-assignment timing (failed shard-core on #5738; the identical code passed on #5780). In-memory builders now pass multiConnection = false so reads serialize behind writes on one connection. Production/file databases keep the multi-reader pool. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.8.0 — stabilization branch
All 2.8.0 milestone PRs have been retargeted onto
release/2.8.0and squash-merged in dependency order. Conflicts + Room schema renumbering were resolved on each PR branch (verified by per-PR CI + local build/lint before merge).Merged (8 PRs)
Schema serialization (resolved)
mainwas at Room v38. All four DB PRs originally claimed v39; serialized by merge order to v39 / v40 / v41 / v42 — each renumbered on its branch (bump version, re-chain@AutoMigration, regenerateNN.jsonvia Room export, kept FTS5's39.json). Each migration validated by Room codegen at build time.Post-merge API fixups (from #5586 AIDL removal)
The AIDL-removal pivot moved/renamed APIs that later PRs consumed; fixed on the respective branches:
DataPacket.{ID_BROADCAST,ID_LOCAL,PKC_CHANNEL_INDEX}→NodeAddress.*(constants moved toNodeAddress)RadioControllermovedcore.model→core.repositoryradioController.getPacketId()→generatePacketId()SendMessageUseCasenow returnsInt(App Functions) atop refactor: Remove AIDL API and modernize service architecture #5586'sContactKeyparsingDeferred
LockdownAuth.max_session_seconds/disable+LockdownStatus.State.DISABLED, merged on protobufsdevelop(#916, #929) but not yet onmaster(no develop→master sync PR open). Add to 2.8.0 in a follow-up once proto syncs. Proto submodule stays at6b1ded4(master HEAD) throughout.Version / CI
VERSION_NAME_BASE→2.8.0(versionCode stays git-derived).release/**to the Pull Request CIbranchestrigger so milestone PRs into the release branch get full CI. (Note: this carries tomainon merge — keep as policy or revert before the release→main merge.)🤖 Generated with Claude Code