Repository navigation
Accessory list fixes, plain-language setup text, specification corrections - #148
Merged
Merged
Conversation
…s name wheel_accessory_show only listed the RS Shifter & Handbrake when its 0x0005 name query had succeeded, so a confirmed accessory whose name read failed was reported as absent while its settings attributes worked. Fall back to the fixed name "RS Shifter & Handbrake", and drop two comments that described the pre-0.43.0 single-name attribute.
Since 0.43.0 wheel_accessory lists every attached accessory, comma separated. accessory_attached() took any value other than "none" as the Shifter & Handbrake, so an H-Shifter or a Racing Adapter on its own switched the handbrake settings on. Look for the accessory's own entry instead, and return only that entry from accessory_name().
Rename the core module to response_view and the toggle rows to "<Axis> response", reword the ten sensitivity and curve help texts, and the curve editor hint, so the apps' user-facing text uses plain words.
Short sentences, one action each, no asides, in the 28 setup strings and the two wheel-specific setup lines. docs/GAME_SETUP.md regenerated.
FFB strength is Nm x 8192 - 1 in both tables; the LIGHTSYNC slot name is 9 characters as the wheel accepts (fn0 advertises 8, one table said 15); the interface note says which interface carries HID++ and which the force stream; the RS50 force packet is a 64-byte report with ID 0x01; the sub-device heading no longer lists fixed indices; SDK symbol counts recounted against the 1.3.11 DLL (75 exports, 58 logi*) and the current ACC build (59 of 63 lookups); wheel_serial and wheel_firmware get an Identity section; wheel_accessory documents the name fallback.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Driver: a confirmed RS Shifter & Handbrake is listed in wheel_accessory even when its name query fails. Apps: the Shifter & Handbrake is picked out of the accessory list instead of any non-none value counting as attached. Per-axis view toggles renamed to "response" and ten help texts reworded. Plain-language pass over the per-game setup strings (GAME_SETUP.md regenerated). Specification corrections listed in the changelog's Unreleased entry.