feat: implement robust access control and security fixes#86
Open
JerryIdoko wants to merge 2 commits into
Open
Conversation
This PR addresses Issue mericcintosun#50 by implementing a robust administrative access control system. Key Changes: - Enabled 'testutils' in Cargo.toml to fix broken test builds. - Implemented 'Admin' authorization for 'set_risk_tier' to prevent unauthorized users from overwriting risk scores. - Added 'initialize' and 'set_admin' functions for ownership management. - Refactored storage to use a clean 'DataKey' enum pattern. - Added a suite of security tests covering authorization and admin transfers. - Cleaned up repository by removing build artifacts from version control and updating .gitignore. This fix ensures that only authorized risk engines/administrators can assign risk tiers, while users retain the ability to authorize their own chosen tier updates.
|
@JerryIdoko is attempting to deploy a commit to the mericcintosun Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #50 by implementing a robust administrative access control system for the risk scoring contract.
Key Enhancements:
Why this is the best solution for #50:
Unlike previous attempts, this PR provides a complete lifecycle for administration (initialization, transfer, and enforcement) and follows modern Soroban patterns. It also fixes the broken build which was preventing other PRs from being properly validated.
Resolves #50