fix(riskTierClient): remove erroneous horizonServer constant and clos…#81
Open
Div1912 wants to merge 1 commit into
Open
Conversation
…e malformed JSDoc
|
Someone is attempting to deploy a commit to the mericcintosun Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed in
src/lib/riskTierClient.ts:Bug 1 ## Summary
Two bugs fixed in
src/lib/riskTierClient.ts:Bug 1 - Wrong server class used for
horizonServerhorizonServeron line 29 was instantiated with the Soroban RPCServerclass (imported from@stellar/stellar-sdk/rpc), not withHorizon.Server. This would return incorrect data if the variable were ever used for Horizon account queries. Since the variable is also unused (account loading already happens correctly insideresolveSourceAccount()via a localnew Horizon.Server(...)call), it has been removed entirely to prevent future misuse.Bug 2 - Unclosed JSDoc comment block
The JSDoc block starting at line 149 was never closed - the
*/was missing before the// --- Contract Clientsection separator. This caused TypeScript (in strict mode) and all documentation generators to parse the next/** ... */block as a continuation of the same malformed comment. The missing*/has been added.Files Changed
src/lib/riskTierClient.tsTesting
npx tsc --noEmit