feat!: remove certificate management from worker #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoccesar
force-pushed
the
augustoccesar/remove-certificate-management-from-worker
branch
from
d8488d6 to
d407c3a
Compare
Use [tungstenite](https://docs.rs/tungstenite/latest/tungstenite/) for handling websocket on local-server. With this implementation we should have a more stable handling of the events and specially of the closing.
…from-worker # Conflicts: # local-server/Cargo.toml # local-server/src/lib.rs # local-server/src/ws.rs
augustoccesar
added a commit
that referenced
this pull request
Aug 29, 2025
### Description We are currently installing Linkup under `$HOME/.linkup/bin` for both Linux and MacOS. The issue with this is that on Linux, we need to use `setcap` to allow the process to bind to process 80/443, which does not work if installed on that location. On Linux, file capabilities (setcap) only work reliably on files located on a filesystem that supports extended attributes and is mounted with them enabled. This changes so that we now install on Linux under `/usr/local/bin`. This requires sudo access on installation, uninstallation and update. This should unblock us to merge #216 Closes SHIP-2224
augustoccesar
deleted the
augustoccesar/remove-certificate-management-from-worker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkup 3 stopped using remote certificate management. So the worker don't need to have this feature anymore.
We are still missing the localdns feature on Linkup 3, but that is currently being fixed on #233. After that, we can consider merging and deploying this.
Closes SHIP-2086