Add remote hypervisor support (ESXi/vCenter/ws-shared) - #2
Open
memoryforensics1 wants to merge 1 commit into
Open
Add remote hypervisor support (ESXi/vCenter/ws-shared)#2memoryforensics1 wants to merge 1 commit into
memoryforensics1 wants to merge 1 commit into
Conversation
VM and guest operations can now target a VM on a remote hypervisor instead of only the local VMware Workstation: - New Vm config fields: HostType, HostUrl, HostUsername, HostPassword - VmwareManager builds the vmrun auth prefix (-T/-h/-u/-p) from config instead of hardcoding "-T ws"; validates host config fail-fast and keeps the old target intact if a runtime switch is invalid - vm_set_target accepts optional host parameters to switch between local and remote hypervisors at runtime - ESXi/vCenter: omit the gui/nogui start argument they reject - Redact -p/-gp/-vp password values in vmrun debug logging - Fix stale test: umd_frida requires guest ops, not an attached Frida session (action="list" is documented to work without attaching) - Add VmwareManagerHostConfigTests covering host config validation and runtime target switching Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VM and guest operations (vm_, guest_, screenshots, file transfer) can now target a VM on a remote hypervisor — ESXi, vCenter, or shared Workstation — instead of only the local VMware Workstation install.
Changes
ServerConfig.cs,appsettings.example.json): newVmfieldsHostType(wsdefault /esx/vc/ws-shared/fusion/player),HostUrl(e.g.https://esxi-host/sdk),HostUsername,HostPassword.VmwareManager: the vmrun auth prefix (-T, plus-h/-u/-pfor remote hosts) is built from config instead of the hardcoded-T wson every call. Host config is validated fail-fast with LLM-friendly errors (remote type without URL, URL without credentials, URL with a local host type).UpdateTargetvalidates before mutating, so an invalid runtime switch leaves the previous target intact.vm_set_target: optionalhostType/hostUrl/hostUsername/hostPasswordparameters allow switching between local and remote hypervisors at runtime (omit to keep the current host,hostUrl=""to return to local).gui/noguiargument tovmrun startis omitted for server host types, which reject it.-p/-gp/-vppassword values are redacted (***) in vmrun debug logging — previously guest passwords were logged in full, and host passwords would have joined them.UmdFrida_FailsWhenNotAttachedexpectedumd_fridato require an attached Frida session, but the tool documentsaction="list"as working without attaching and each eval/inject spawns a fresh frida process. Rewrote the test to match the documented design.VmwareManagerHostConfigTests(10 tests) covering host config validation and runtime target switching.Notes
esx/vc,VmxPathis a datastore path like[datastore1] win10/win10.vmx.Testing
dotnet build— clean, 0 warningsdotnet test— 136/136 pass (was 125/126 before: 1 pre-existing failure fixed, 10 tests added)🤖 Generated with Claude Code