Skip to content

fix(reputation): scope post rating history to viewer access - #452

Merged
jouwdan merged 2 commits into
mainfrom
codex/reputation-history-audience
Oct 31, 2026
Merged

jouwdan merged 2 commits into
mainfrom
codex/reputation-history-audience

Conversation

@jouwdan

@jouwdan jouwdan commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

Post-rating comments and thread links were visible on member reputation pages even when viewers could not read the underlying discussion. Pass the viewer’s ThreadAudience through history reads and filter against the live thread forum, own-thread restrictions, and visible post/thread states before pagination. Profile ratings and aggregate totals remain visible.

Validation: new privacy regressions fail against the original implementation; all 45 focused tests pass; pnpm verify passes (9,425 tests); pnpm comments:check passes. Documentation includes the required audience contract for custom repositories.

Addresses finding #5 in the post-v0.38.0 audit.

@jouwdan
jouwdan force-pushed the codex/reputation-history-audience branch from 0aadebc to f49442f Compare October 31, 2026 13:52
@jouwdan
jouwdan merged commit 536dcea into main Oct 31, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant