fix last on iterators with dup values#352
Open
Boog900 wants to merge 1 commit intomeilisearch:mainfrom
Open
Conversation
Kerollmops
requested changes
Nov 20, 2025
Member
Kerollmops
left a comment
Kerollmops
left a comment
There was a problem hiding this comment.
Thank you @Boog900 for this PR, it's a breaking change, and would it be possible to document the last method about this specific behavior, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
From what I can tell in the
lastmethod for the iterators we are checking if the current key we are pointing at is equal to the last key so that if we have already gone through the iterator we returnNone. This doesn't work for dup tables though as the values may be different even if the key is the same (I added a test case that fails).Although this PR removes this entirely, always returning a value for
last, even if the iterator has already returnedNonefromnext. The main reason is this simpler and there is no requirement that once an iterator returns None that it wont return Some again: https://doc.rust-lang.org/std/iter/trait.Iterator.html#tymethod.nextSorry if I missed something that makes this change invalid though!