Introduce better support to acquire global database handles#154
Open
Kerollmops wants to merge 4 commits intomainfrom
Open
Introduce better support to acquire global database handles#154Kerollmops wants to merge 4 commits intomainfrom
Kerollmops wants to merge 4 commits intomainfrom
Conversation
03c06a6 to
255e88c
Compare
255e88c to
59bbbc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first point of #144 which is:
About the second point below, we should only allow write transactions to create or open databases. It would be valid to open all the available databases at the first env opening, they are listed in the main database (
name = NULL), and these names can be mixed with data. The issue is that heed is a typed key-value store, we must ask the user for the type of a database, maybe with a function given to theEnvOpenOptions.