test: add Rex4 system contract deployment and idempotence tests -v2#203
Open
viktorcrypt wants to merge 3 commits intomegaeth-labs:mainfrom
Open
Conversation
viktorcrypt
force-pushed
the
viktorcrypt/test/rex4-system-contract-deployment-v2
branch
from
2fcaa26 to
ee21de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Rex4 deployment tests for
MegaAccessControlandMegaLimitControl, covering:apply_pre_execution_changes()Also incorporates the requested review follow-up:
with_all_activated()KECCAK_EMPTYfor the non-deployed caseNote
This PR replaces #187, which got stuck due to a GitHub fork-lineage issue after the repository outage. All review feedback from Troublor has been incorporated here. Please consider closing #187 in favor of this one.