Skip to content

Fix media upload in MatrixHttpApi#4

Open
lordgurke wants to merge 1 commit into
meet-kinksters:masterfrom
lordgurke:fix-media-upload-20230411
Open

Fix media upload in MatrixHttpApi#4
lordgurke wants to merge 1 commit into
meet-kinksters:masterfrom
lordgurke:fix-media-upload-20230411

Conversation

@lordgurke

Copy link
Copy Markdown

Description

Due to a bug, media uploads (i.e. images, audio files) were not working, as the content would always be handled as a JSON file and binary data would break the JSON linter.
This fix also changes the way file contents (if not JSON) are uploaded with Guzzle, as it now is transfered as HTTP body (as per matrix.org API documentation).

How has this been tested?

This was taken out of a working live system patch.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes. (API related, no automated testing)
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant