Proposed retention policy change#1
Open
slobberchops wants to merge 8 commits into
Open
Conversation
Fixes: - Update create-db-snapshot.sh to use mediasci:env=$stage instead of mediasci:env:$stage=true - Update list-db-snapshots.sh filter to match new tag format - Ensure consistent tagging between snapshot creation and listing scripts
Fixes: - Update README.mediasci.md to reference correct script name set-secrets.sh - Replace non-existent upload-secrets.sh with actual set-secrets.sh script
Fixes: - get_stack_output function now returns empty string when CloudFormation stack doesn't exist - Preserves error propagation for permission and network issues - Allows scripts to run gracefully when optional stacks are not deployed
Changes: - Clarify that firstrun.sh script downloads secrets from Parameter Store on first boot - Document that script writes decrypted secrets to .env file for LibreChat service - Add warning that instances must be recreated to change secrets since script only runs once
Features: - Add start-local-librechat.sh script with environment file support - Add stop-local-librechat.sh script for stopping local services - Support custom environment files via -e flag Changes: - Update docker-compose.mediasci.yml to use ENV_FILE variable with .env default - Add local development documentation section to README.mediasci.md - Add new scripts to Development Tools command reference
Features: - Add mediasciChatUtils.js with enforceMaxRetention utility function - Set 3-hour maximum retention period for all chats regardless of temporary settings - Enforce retention limits in both Message.js and Conversation.js saveMessage/saveConvo functions Changes: - Import enforceMaxRetention in Message.js and Conversation.js with MEDIASCI markers - Apply retention enforcement after existing temporary chat logic - All chats now expire within 3 hours maximum via MongoDB TTL indexing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal to enforce a maximum retention period is likely the simplest way to patch the project such that conversations are forgotten after our desired period of time. It makes no modifications to the UI, so the UI becomes somewhat inconsistent.
I gussy'ed it up in a way that it will hopefully be easy for us to find these changes and patch them into future changes. Who knows.