Parsing - Optimize token consumption#164
Merged
igorkramaric merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
igorkramaric
changed the title
igorkramaric
deleted the
explore-optimization-for-daffodil-keys-method
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#165
Motivation
keysis a Cython-exposed attribute onDaffodiland is populated while constructing the predicate, so predicate/token parsing is on the hot path for collecting keys.list.pop(0)calls which are O(n) each and cause noticeable lag when running over thousands of expressions.