This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Open
Conversation
In my project sometimes it fails to handle response. I propose not to check client connected on RX No side effects revealed
Codex-
reviewed
Feb 2, 2020
| void AsyncTCPbuffer::_rxData(uint8_t *buf, size_t len) { | ||
| if(!_client || !_client->connected()) { | ||
| //FIX do not check connected here, otherwise miss responce | ||
| if(!_client/* || !_client->connected()*/) { |
There was a problem hiding this comment.
Leaving this commented inline seems messy, either leave it or further flesh out the rationale behind removing the check imo
adam00s
pushed a commit
to adam00s/ESPAsyncTCP
that referenced
this pull request
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project sometimes it fails to handle response. I propose not to check client connected on RX
No side effects revealed