Antisymmetry BC with surface-piercing topology#287
Draft
gawng wants to merge 28 commits intomdolab:mainfrom
Draft
Antisymmetry BC with surface-piercing topology#287gawng wants to merge 28 commits intomdolab:mainfrom
gawng wants to merge 28 commits intomdolab:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
===========================================
- Coverage 41.02% 27.57% -13.45%
===========================================
Files 13 13
Lines 4119 4119
===========================================
- Hits 1690 1136 -554
- Misses 2429 2983 +554 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This needs more test cases before it is ready for merging.
The antisymmetry BC is appropriate for high-speed foils near the free surface for modelling the loss of lift and increase in drag. This PR contains the antisymmetry option that works for surface-piercing topology (e.g., a strut).
Expected time until merged
Summer 2024
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable