Conversation
|
ce08a77 was deployed to: https://fred-pr1279.review.mdn.allizom.net/ |
Add missing toggle event handler for data-glean-toggle-open attribute. Fixes #1035
7f33adc to
e453d13
Compare
Instead, measure the top nav login in the `user-menu` component, which does NOT use the `login-button` component.
caugner
left a comment
There was a problem hiding this comment.
Reviewed all changes, will test next.
Glean Measurement Testing Checklist
Accessibility Menu (
|
🐛 Also fires when selecting an item.
🐛 Fires both on open and close.
🐛 No event observed (maybe because the
Need to test locally.
Need to test locally.
🐛 No event.
🐛 Fires when item is selected, not when the select is opened.
Need to test locally. |
Description
Adds several missing Glean measurements, and corrects some.
Motivation
Ensure we can make data-driven decisions about the affected features.
Additional details
Related issues and pull requests
Related to #647.
Fixes several issues, mentioned directly in the commits.