Skip to content

Add FileSystemObserver demo#297

Merged
bsmth merged 1 commit into
mdn:mainfrom
chrisdavidmills:filesystemobserver-example
Feb 27, 2025
Merged

Add FileSystemObserver demo#297
bsmth merged 1 commit into
mdn:mainfrom
chrisdavidmills:filesystemobserver-example

Conversation

@chrisdavidmills

Copy link
Copy Markdown
Contributor

This PR adds a FileSystemObserver example to the repo, as per the conversation at mdn/content#38270 (comment) and follow-up at mdn/content#38270 (comment)

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner February 27, 2025 13:56
@chrisdavidmills chrisdavidmills requested review from bsmth and removed request for a team February 27, 2025 13:56

@bsmth bsmth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bsmth bsmth merged commit 05944b1 into mdn:main Feb 27, 2025
@wbamberg

Copy link
Copy Markdown
Contributor

@chrisdavidmills

Copy link
Copy Markdown
Contributor Author

On Firefox, https://github.com/chrisdavidmills/dom-examples/blob/6729dc1a0d1a050a64add4b364ff8fceb14dca69/filesystemobserver/random.js#L3 throws with:

Uncaught (in promise) TypeError: rootHandle.remove is not a function

...so the code at https://github.com/chrisdavidmills/dom-examples/blob/6729dc1a0d1a050a64add4b364ff8fceb14dca69/filesystemobserver/random.js#L11-L13 doesn't get to run.

Yup. This is because the remove() method is not supported outside Chromium. But then again, neither is FileSystemObserver.

@wbamberg

Copy link
Copy Markdown
Contributor

I've filed this as #298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants