fetchLater corrections and updates#39118
Merged
Merged
Conversation
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs
(comment last updated: 2025-04-15 14:29:22) |
Josh-Cena
requested review from
chrisdavidmills
and removed request for
sideshowbarker
Josh-Cena
reviewed
Apr 14, 2025
Josh-Cena
reviewed
Apr 14, 2025
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
chrisdavidmills
requested changes
Apr 15, 2025
chrisdavidmills
left a comment
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
@tunetheweb looking mostly good; just a few bits for you to look at.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
chrisdavidmills
approved these changes
Apr 15, 2025
chrisdavidmills
left a comment
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
@tunetheweb very nearly there! Just a couple of small suggestions to consider, then we can get this merged.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed some of the
fetchLaterexamples added in #39016 (copied over from incorrect examples in the explainer - so will correct those too!).And also added a couple more quota examples from people who have reached out with some edge-cases that weren't covered.
Motivation
Help developers!
Additional details
Related issues and pull requests
WICG/pending-beacon#104