Track eval scenario digests per size in the comparison - #70
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 94.41% 94.37% -0.04%
==========================================
Files 93 93
Lines 7695 7697 +2
Branches 1604 1604
==========================================
- Hits 7265 7264 -1
- Misses 97 101 +4
+ Partials 333 332 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario digests are computed per size, but the comparison keyed them by scenario name only. A baseline holding S and M rows therefore read a candidate that had run only the S tier as three changed scenarios and reported nothing comparable, which is what the compaction-eval workflow just did on #68. The comparison now tracks digests per scenario and size and names a changed workload as scenario/size.
Like the grader fix, this has to land on main first: the compare job grades with the base branch's code by design.
Verified with the eval tests and RuboCop.