Compare numbers without bigdecimal in the eval grader - #69
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 94.37% 94.37% -0.01%
==========================================
Files 93 93
Lines 7696 7695 -1
Branches 1604 1604
==========================================
- Hits 7263 7262 -1
Misses 101 101
Partials 332 332 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval grader required bigdecimal to compare numbers exactly. On Ruby 3.4 bigdecimal is a bundled gem, and the compaction-eval jobs install without the Gemfile groups that pulled it in transitively, so every eval and compare job failed at boot the first time the workflow was approved to run. Rational compares the same decimal strings exactly with no dependency.
The compare job deliberately grades with the base branch's code, so this has to land on main before any pull request's comparison can run.
Verified with the eval tests, RuboCop, and the eval CLI booting under Ruby 3.4 with the workflow's bundle groups.