cli: add parser config to allow note ID as hex string#90
Open
etiennedm wants to merge 2 commits into
Open
Conversation
etiennedm
force-pushed
the
cli-hex-node-id
branch
from
cd736c3 to
3ca7899
Compare
etiennedm
force-pushed
the
cli-hex-node-id
branch
from
3ca7899 to
198c3d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see any reason why we could not accept a hexadecimal string as the node ID. I was looking at a Wireshark trace which displays node IDs as hex, and this would avoid the mental gymnastic to convert back to a decimal value!