Fix returned error and process notification bug when handing SDO requests in NodeMbox#83
Merged
Merged
Conversation
Owner
|
Actually I think it's even worse, no process notifications were being made for SDO requests! Actually all messages with the SDO request ID should be handled, and the sdo_comms return value indicates if further processing is needed in the main process context or not (e.g. for block uploads the entire block is collected before processing is triggered). I updated the logic and added a test to demo. Thanks for finding it. |
Owner
|
This will close #82 |
mcbridejc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check
sdo_comms.handle_reqreturn value to avoid returning anErrfromNodeMbox::store_messagewhen handling is successful