refactor: remove findFilePath dead code path and make cache required#295
Merged
Conversation
The no-cache fallback path always returned undefined and was never reachable in practice (both callers in coverageTransformer always supply a filePathCache). Removed the optional wrapper, inlined the cache lookup as the exported function, and made filePathCache a required parameter. Deleted the two tests that covered the dead path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findFilePathalways returnedundefinedand was unreachable — both callers incoverageTransformer.tsalways supply afilePathCachefilePathCachea required parameterwithout cachedescribe block)findFilePath.tsshrinks from 41 lines to 14Test plan
npm run test:only) — 100% coverage (203/203 branches)🤖 Generated with Claude Code