fix: guard against NaN line-rate in Cobertura when no lines tracked#292
Merged
Conversation
finalize() computed package and global line-rate via division without guarding for a zero denominator. A file with no tracked lines (empty lines object) produced NaN in both values, silently breaking every downstream tool that reads line-rate from the Cobertura XML. Both division sites now return 0 when the denominator is zero. Extended the existing empty-file test to assert package and global line-rate are 0, not NaN. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalize()inCoberturaCoverageHandlercomputed package and global@line-ratevia division without guarding for a zero denominatorNaNin both values, silently breaking every downstream tool that readsline-ratefrom the Cobertura XML (Codecov, Azure DevOps, Jenkins, GitLab, etc.)0when the denominator is zeroTest plan
pkg['@line-rate']andresult.coverage['@line-rate']are0, notNaNnpm run test:only)🤖 Generated with Claude Code