Repository navigation
Reduce Linux raw filename output overhead - #1154
Conversation
Benchmark previewAdvisory: changes over 15% are warnings, not merge failures. Positive reference-adjusted change means slower; negative means faster. linuxPerformance overviewWARNING: 1 comparison(s) exceed the 15% slowdown threshold. Advisory only. Merged baseline: 52950f9; run 42534134015, attempt 1; mean of fastest 7/9 runs. Compatible comparisons: 360/360; unavailable: 0.
Largest regressions:
Typical change is an equal-weight geometric mean of reference-adjusted XFF/main factors. Negative is faster; positive is slower. These correlated cases are not a significance test. Tested merge macosPerformance overviewNo compatible merged baseline comparisons are available; regression status is unknown. Advisory only. Merged baseline: unavailable. Compatible comparisons: 0/360; unavailable: 360.
Typical change is an equal-weight geometric mean of reference-adjusted XFF/main factors. Negative is faster; positive is slower. These correlated cases are not a significance test. Tested merge |
Reduce Linux filename-output work with a reusable inline buffer. Qualified production binaries show about 1-1.5% less elapsed time for 100,000-file listings at three workers, and separate counters show about 2.1% fewer userspace instructions. macOS keeps its previous implementation following its qualification.
Refresh the merged-PR coverage inventory and verify that recovered PRs #914, #986 and #1143 load charts on both platforms.
AG;DR
Scope and implementation
This follows merged #1151 (
ed883ecc527bc551e778845d054afc27c9b6b024). Current head1f37b3cc846efa0541396daf84d984f24ed565e5contains that main commit locally and remotely. The synchronization preserves both release-site page/asset maps. No runtime edits followed the synchronization.RawRecordBufferhas 256 bytes of coordinator-owned inline storage. Initialize only the accepted path prefix and terminator; use the existing bounded string fallback for longer records.No flags, benchmark recipe, sample population or viewer contract change. Extended-history integration remains separate in #1153; the missing benchmark-history backlog is not declared complete.
Current-head verification
-flto=thinon both hosts. Mac image:a4d4f82703982e562aa1c8bdb71782c5bd67d4fc9101cb7b861f40d3dbd8b4ab, 4,223,056 bytes. Linux image:455ee7cf849dafdb19b797165ed7e976018596df1df5ddf8929e818b0cde8578, 12,826,528 bytes.42564885437and Benchmarks42564885478both succeeded. Final PR Test run42566803779, attempt 5, completed successfully on this exact qualified head. All required checks pass, including finaldone.Integrated production measurements
Measure the actual frozen lean executables against a main-equivalent #1151 image and an independent copy of that baseline. Stop build servers before timing and verify image hashes afterward. Every invocation checks complete output against an independent oracle, exit status and diagnostics; recompute all retained means.
Both hosts complete 76 ordinary cases, three sessions of nine measured rounds retaining seven, with discarded warmups: 6,840 checked invocations each. Descriptive candidate/control geometric ratios are Linux
0.996617 / 0.998538and Mac1.001438 / 0.998967. These population summaries do not establish universal speedups.Keep every initially slower Linux observation. One selected confirmation includes all geometric candidate costs over 3% or costs positive in all three sessions: twelve cases, three sessions of 27 rounds retaining 21, 3,024 checked invocations. None remains positive in every confirmation session; the largest repeat point estimate is +0.54%, with copy control +0.46%. The original observations remain retained rather than being replaced by the repeat.
The separate Linux listing screen uses 100/100,000 files, broad/deep trees and workers 1/3/10, with three sessions of 27 rounds retaining 21. Rotate baseline/copy/candidate/GNU find; all 4,032 checked invocations pass. All twelve candidate point estimates improve. Large/three-worker geometric change is -1.40%, copied control +0.12%; candidate/find is 1.1005, so this does not claim to beat find. After an EDQUOT setup failure with no accepted timings, remove only the recorded private partial fixture and verify all retained extended-production-v1 fixture contents, metadata and population before reuse. Do not label this recipe as canonical CI data.
Separate post-timing counters cover 54 checked invocations with 100% scheduling: instructions fall 2.17% for broad/single-worker and 2.12% for deep/three-worker at 100,000 files; copy controls are effectively unchanged. Profiled durations never enter elapsed populations.
Final Mac code/data contents and addresses, dyld bindings and function metadata match merged main; only
LC_UUIDdiffers. Its integrated ordinary screen uses retained APFS temporary fixtures without affinity, separate from the original RAM-image experiment. No Mac speedup is claimed. Linux pins OS-reported distinct cores without claiming physical-host isolation.Original experiment and retained evidence
The original report remains frozen at source
90f8c8c0579b1132ea4d0bc714da9f855a77e012, before #1152 integration, against #1151 source1ea02a41d7dcf25c043e1079c98a9e60d6d73290. It separately records actual full/minimal release images, the five-task 90-case grid, all slower controls, 32 final-screen cells and 2,688 checked invocations per host, the rejected Mac portable experiment and RAM-image ownership/release receipts. Its full/minimal results are not relabeled as the integrated lean measurements above.Public report and lossless qualification summaries:
docs/benchmarks/linux-inline-raw-records-20261109.{md,json}. Durable integration archives on drogon retain actual executable bytes, raw samples, scripts, oracles, logs, source bundle and identities:/home/marcus/Documents/xff-pr1154-integration-linux-qualified-1f37b3c-20261109.tar.gz: 13,354,890 bytes; SHA-25638aa03e3bf71a6b97e3f5695b64226d2cce0426143ff654625805b9f0cf40400./home/marcus/Documents/xff-pr1154-integration-macos-qualified-1f37b3c-20261109.tar.gz: 5,376,859 bytes; SHA-256aff6ab8f1063eb992ce3afcfdd4051fb5878d97d0c573f65b55516f95ebb1ab3./home/marcus/Documents/xff-pr1154-integration-coverage-complete-1f37b3c-20261109.tar.gz: 330,465 bytes; SHA-25619c9baae644094076de5f5a184d82432e7a4d50cbd42e6f0025163dbbc29dc5a; original raw LCOV verified inside.Transferred copies are independently hash-checked. Access to the project host is required. Original pre-integration archives remain documented in the frozen report. Mac command metadata was reconstructed from the unchanged executed script after collection overwrote its local command JSON; original raw suite logs and terminal success remain retained with explicit provenance.
Benchmark coverage inventory
Refresh the dated direct-main-merge inventory: 237 expected, 162 published on both platforms and 75 missing in the snapshot. Development-branch merges are excluded. Record existing recovery jobs without redispatching successful work. Chromium selects #914/#986/#1143 in both published CI datasets, loads their actual figure payloads and reports no page errors. Preserve their conservative binary verification state and historical workflow-driver mismatch; do not bypass it. This inventory update does not claim completion of the missing-run backlog or extended-history publication.
Final CI performance review
Both official aggregate reports pool nine measured samples and retain the fastest seven. Linux matches all 360 comparisons to current main run
42564885478: median normalized change -0.074%, with no 15% regression alarms. Mac reports no compatible historical main baseline, so no normalized CI regression claim is made there; retain the independent local qualification and identical loaded-code/data proof. Both reports contain executable provenance receipts. GitHub measured synthetic merge7f88c94cfe1c949d229e46c77cc41a2d6d895c55; its verified parents are current main and the PR head, and its tree exactly matches the qualified PR tree. No recorded artifact commit was relabeled.