Repository navigation
Avoid eager stats for lexical listing templates - #1134
Merged
Merged
Conversation
…blication' into perf/direct-language-json-storage
…e' into docs/o27c-hinted-ancestor-qualification
…ication' into fix/main-benchmark-fourth-agreement
This was referenced Nov 7, 2026
Base automatically changed from
docs/archive-btree-historical-qualification
to
main
November 7, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexical listing templates can render paths, names and supplied context without requesting unused file attributes. Compile their metadata requirements once and preserve eager metadata for columns and fields that need it. Both-host measurements show targeted gains with explicit control costs.
AG;DR
Implementation and correctness
--templateoutput. Columns remain eager on every platform and worker count. Expression metadata, unknown/directory/followed-link traversal, safety, colors, reductions, collections, deferred evaluation and native-case requirements remain independent. Mixed{name}:{size}output still requests metadata.Evidence, selection and limits
docs/benchmarks/compiled-field-stat-demand-20261107.mdand its lossless 6,954,149-byte capsule retain 629 individually verified records / 73,562,227 decoded bytes. SHA-256b52cc8687dd213cda89b958b31ca912c4846d8f9d00ae32714227d7afdbbd8be. Report HTML and a supported raw-file download mapping are registered; the large-file exemption matches this exact filename. No historical measurement is removed.The earlier combined template/column policy is rejected: Linux many-directory/10,000-file/three-worker TSV repeatedly costs about 24%, despite favorable cohort medians. Preserve initial screens, the correctness failure, corrected combined populations, all source/image identities and slower cells. Do not reopen it unchanged or pool its samples with the selected variant.
Template-only qualification uses exact main
1786340680499f50b08dee5b1ceffbc20fd7b533, with 80 in-memory production RunFind cases and 64 independently output-checked native CLI cases per host, three balanced sessions, nine raw repetitions and fastest seven retained. Include the unchanged image repeat and every column/plain/size control. Linux uses physical-core affinity; macOS has no affinity claim. Actual shipping compile/link/config/image receipts are archived; no peak-RSS, cold-cache or archive-specific speedup is claimed.Column pipeline causes, score-consumer-specific demand and conditional stat-bearing admission remain separate open work. No selective favorable rerun, normalization or subtraction hides costs.
Dependencies and validation
This is a separately reviewable child of #1133 (
3c68a363f201e1f0f6222645cae0fa60568342a1), following #1129 → #1130 → #1131 → #1132 → #1133. Preserve each merge and its benchmark automation. Parent reports/tracking and the workflow correction are retained; no ready ancestor was modified. The six runtime/build/test input files were identical between the experimental main and this public parent, and all six final source hashes plus the frozen report/capsule remain byte-identical after normal publication hooks.Development qualification passed all 323 documented core/registered-extension release targets on both hosts, seven focused ASan targets on both, and seven focused MSan/TSan targets on Linux. The unchanged-parent proof reproduces eight expected template failures (1,001 stats versus one); column expectations remain unchanged. Seven bounded optimized integration suites also passed in this successor worktree (all cached, zero freshly executed); this is development feedback, not public readiness.
All 629 evidence record lengths/hashes, site configuration/page/file mappings, exact allowlist positive and negative controls, canonical table alignment, diff checks and 32 release-site tests pass. Changed-file Trunk formatting/checks and normal signed commit/push hooks pass;
SKIP=clang-tidyis supplied as requested, and no local clang-tidy executable ran. Signed head4cebe20c36675fad9422645310154342783474c7preserves the measured six source inputs exactly. This PR must pass its own actual pushed-head CI, including GCC, coverage, sanitizers, CI clang-tidy, final benchmark comparison and required done/pre-commit/trunk checks; private or ancestor results do not substitute. After retargeting to main, synchronize/push immediately and require its own new main-context validation before merging.Current main integration
Signed synchronization
a5fafd3c9cf8401030f5da49f41bcad31ad2b7c6incorporates #1133 actual main squash5b2e3847beb26d27ca569e559ee69e1e302d4448. Strict proof verifies that the real included old parent, qualified signed parent and actual squash have equal complete trees. The entire qualified child tree141a4c6313dcef357a87629c18a7495199a11bf9is preserved, including all runtime, test, report and capsule bytes. Normal signed commit and immediate push hooks passed; normal merge hooks intentionally skip redundant Trunk. No local clang-tidy, private timing or unchanged source test rerun was performed.Own fresh current-main Test run 42383967956 completed successfully on signed head
a5fafd3c9cf8401030f5da49f41bcad31ad2b7c6: all platform tests, GCC, sanitizers, coverage, actual CI clang-tidy, pre-commit, Trunk, final best-7-of-9 benchmark comparison and required done passed. All six initial measurement shards and the fourth macOS candidate passed; after-fourth agreement succeeded and both fifth candidates skipped normally. Exact predecessor-main Test 42383864867 also completed successfully. Earlier stacked CI and private qualification remain historical evidence and do not replace these checks. The user explicitly requested this PR after #1133; #1133 has now merged.