Repository navigation
ConfigStore: recover from read errors, watch a missing config directory - #203
Merged
Merged
Conversation
…t does not exist yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
ConfigStorefixes: (1)reloadConfignow revalidates identical bytes while aconfigProblemis set, so a restored file clears read-only; (2)startWatchingwatches the nearest existing ancestor while the config directory is absent and rearms as directories appear (event-driven).How checked
New tests:
aReadFailureClearsOnceTheIdenticalFileIsBack,watchingAMissingDirectoryFollowsItsCreation(temp dirs only).Docs
docs/companion.mdwatching paragraph updated.Agent evidence
swift buildok;swift test --filter PureMouseAppSupportTests: 530 tests, both new tests pass. 8 issues in unrelated tests under the lane sandbox: NotificationPermissionTests, UpdatePreferencesWatchTests (defaultssubprocess), ConfigFileBackupTests symlink path (/private resolution). Not touched by this change.