Repository navigation
Fix overlapping middle click holds - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep a middle click held until the last control releases it. Overlapping Middle Click bindings and the native wheel-press fallback now share the same system button hold; duplicate presses do not post extra downs.
How checked
swift buildsucceeded with Swift 6.4.2.swift test --filter 'MiddleClickHoldTests|HeldButtonsTests'passed (10 tests), covering overlaps, both native fallback orders, duplicate presses, failed posting, and cleanup.Footprint
No footprint rig run: the change adds no timers or polling and retains only existing per-control sets. Before/after memory and bundle size were not measured.
Docs
No documentation changes: this corrects the existing held-click behavior, with no config or UI changes, and the requested write scope excludes docs.
Agent evidence
git diff --checkpassed.