Skip to content

Fix overlapping middle click holds - #201

Merged
mblauberg merged 1 commit into
mainfrom
lane/middle-hold
Nov 4, 2026
Merged

mblauberg merged 1 commit into
mainfrom
lane/middle-hold

Conversation

@mblauberg

Copy link
Copy Markdown
Owner

Summary

Keep a middle click held until the last control releases it. Overlapping Middle Click bindings and the native wheel-press fallback now share the same system button hold; duplicate presses do not post extra downs.

How checked

  • swift build succeeded with Swift 6.4.2.
  • swift test --filter 'MiddleClickHoldTests|HeldButtonsTests' passed (10 tests), covering overlaps, both native fallback orders, duplicate presses, failed posting, and cleanup.
  • No live mouse or daemon was used.

Footprint

No footprint rig run: the change adds no timers or polling and retains only existing per-control sets. Before/after memory and bundle size were not measured.

Docs

No documentation changes: this corrects the existing held-click behavior, with no config or UI changes, and the requested write scope excludes docs.

Agent evidence
  • git diff --check passed.
  • Reviewed native button mappings: wheel press shares middle; back and forward have distinct native button numbers, and Drag Lock is a single toggle.
  • Build and filtered tests passed on Swift 6.4.2; compilation emitted warnings in untouched files. CI covers Swift 6.3.
  • No matching open issue was found by searching for middle click hold.

@mblauberg mblauberg added the bug Something isn't working label Nov 4, 2026
@mblauberg
mblauberg merged commit 31d34b4 into main Nov 4, 2026
2 checks passed
@mblauberg
mblauberg deleted the lane/middle-hold branch November 4, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant