Repository navigation
Fix export validation of freshly read config bytes - #200
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export Settings now validates the exact bytes it reads before writing the destination, using the same validation and field error formatting as config loading.
Previously, loading
{"dpi":800}and then overwriting the file with{"dpi":999999}without reloading let export succeed with an invalid file. Export now returns the DPI range error and leaves the destination absent.How checked
exportRefusesInvalidBytesWrittenSinceTheLastLoadusing temporary Sandbox directories.swift test --filter ConfigTransferTests.exportRefusesInvalidBytesWrittenSinceTheLastLoadreproduced both failures: export returned nil and created the invalid destination.swift build && swift test --filter ConfigTransferTestspassed: 10 tests.git diff --checkpassed.Footprint
No daemon or menu app changes. Validation runs only when exporting.
Docs
No update needed: docs/configuration.md already guarantees that a config that does not load is not exported. This fixes implementation of that guarantee.
Agent evidence
63b7b9c; commit:1a2f855.