Skip to content

Patch for /src/cb/condition-builder.js #7

Description

@GoogleCodeExporter
Added '> div > table' to lines 126, 127 and 130.  This stopped the query 
builder looping through all inner tables multiple times.  When choosing the 
following:

(and)
code contains test1
(add +() set to and)
country contains test2
government contains test3
(add +() set to and)
continent contains test4

When running it with the original file, it produces this:

( code contains test1 and ( country contains test2 and govt contains test3 and 
( cont contains test4 ) ) and ( cont contains test4 ) )

Notice "cont contains test4" is repeated.  If you add the find to look for '> 
div > table', it will only search each table once, in the order they are 
displayed and produce the following output:

( code contains test1 and ( country contains test2 and govt contains test3 and 
( cont contains test4 ) ) )

Original issue reported on code.google.com by pete.sli...@gmail.com on 23 May 2013 at 4:52

Attachments:

Activity

  1. GoogleCodeExporter commented on Feb 8, 2016

    @GoogleCodeExporter
    Author
    Hello Pete,
    I tried your solution but it's not working for me.
    Are you sure that the patch you gave fix this issue?
    Anyway thanks for sharing and for suggesting a solution
    
    

    Original comment by mlef...@gmail.com on 19 Jul 2013 at 7:09

  2. GoogleCodeExporter commented on Feb 8, 2016

    @GoogleCodeExporter
    Author
    find the full fix .js
    

    Original comment by ikram.tr...@gmail.com on 20 Nov 2013 at 8:18

    Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions